Use the dependencies declaration to specify test dependencies #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than embedding them in the tox.ini
|
Just a note, some maintainers are packaging this theme for some distributions, and they include tests (so they also need to package the test dependencies), I wasn't able to find the conversation, but would be nice to not have maintainers package the I think it probably makes sense to have those tests in https://github.com/readthedocs/readthedocs-sphinx-ext, or have them conditionally run or something. |
|
I'll withdraw this one - it wasn't working with tox, and I don't know it well enough to figure out the magic incantation. Furthermore, it seems that the desired solution isn't to correctly document the dependency, but rather to remove that dependency from the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the dependencies declaration to specify test dependencies, rather than embedding them in the tox.ini
cc @agjohnson following on from #1345 (comment) (which I reverted in that PR)